Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TW server 增加對台服的支持 #114

Merged
merged 10 commits into from Aug 28, 2023

Conversation

miquve
Copy link
Contributor

@miquve miquve commented Aug 26, 2023

增加對台服的支持, 新增以下圖片模版:

  • arts.png
  • buster.png
  • cardsealed.png
  • charasealed.png
  • defeated.png
  • dropitem.png
  • hougusealed.png
  • quick.png
  • still.png
  • synthesis.png

更新fgoDetect.py 以增加台服相關功能

  • 由於寶具無法正常使用, 參考 Added support for NA servers #111class XDetectTW增加def isHouguReady, 經測試在更改後可正常進關戰鬥, 使用技能及寶具

  • class XDetectTW中的ocr沿用ocr=OCR.ZH, 等待上游更新倘有的繁中支持

更新fgoConst.py以增加台服package名稱

  • [**********][WARNING]<fgo.Detect> Package: com.xiaomeng.fategrandorder, Region: TW

@hgjazhgj
Copy link
Owner

非常感谢您的贡献! 请原谅我使用简体中文与您交谈

更新fgoConst.py以增加台服package名稱

  • [**********][WARNING]<fgo.Detect> Package: com.xiaomeng.fategrandorder, Region: TW

请问原有的com.aniplex.fategrandorder.tw是一个真实存在的台服package吗?
如果不是的话麻烦帮我把它删掉,当时copilot给我自动补全了就没多想 :)

@hgjazhgj hgjazhgj changed the base branch from master to dev August 26, 2023 05:34
@hgjazhgj
Copy link
Owner

你所添加的图片与现有的具有不同的尺寸,请遵循以下规范:

  1. No matter how you get them, all images should be eventually saved by cv2.imwrite(filename,image,[cv2.IMWRITE_PNG_COMPRESSION,9])
  2. The image you add needs to have the same number of channels as the existing image, usually 4 channels of RGBA
  3. If the image you add has an Alpha channel, then this channel can only have two values: fully transparent (0) and fully opaque (255), and the transparent pixel itself must be pure black
  4. If you do not override the recognition method in XDetectTW, then the image you add needs to be precisely the same size as the existing image, and taken from the same area as the existing image if possible
  5. If you override the recognition method in XDetectTW, then the crop area in this method needs to be 2px larger than the actual cropping area of the image template in each direction, which means that your image template must not contain 2px of the edge of the game screen

@miquve
Copy link
Contributor Author

miquve commented Aug 26, 2023

请问原有的com.aniplex.fategrandorder.tw是一个真实存在的台服package吗? 如果不是的话麻烦帮我把它删掉,当时copilot给我自动补全了就没多想 :)

com.aniplex.fategrandorder.tw 應該並不存在, 已移除

@miquve
Copy link
Contributor Author

miquve commented Aug 26, 2023

你所添加的图片与现有的具有不同的尺寸,请遵循以下规范:

感謝指正, 更新的圖片模版是從FGO-Py的「檢查截圖」存檔後, 再手動以小畫家裁剪而成. 我注意到你已對圖片作出更動commit, 我還需要更新嗎?

@hgjazhgj
Copy link
Owner

hgjazhgj commented Aug 26, 2023

感謝指正, 更新的圖片模版是從FGO-Py的「檢查截圖」存檔後, 再手動以小畫家裁剪而成. 我注意到你已對圖片作出更動commit, 我還需要更新嗎?

需要
该commit只是保证了第1,3条,你需要至少提供至少符合第2,4,5条标准的图片
特请注意:「檢查截圖」保存的图片只有RGB三通道

@miquve
Copy link
Contributor Author

miquve commented Aug 28, 2023

重新製作tw圖片模版, 請檢查

@hgjazhgj hgjazhgj merged commit 52972e0 into hgjazhgj:dev Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants