Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript definition files #98

Closed
hozjanmarko opened this issue Jun 6, 2016 · 3 comments
Closed

typescript definition files #98

hozjanmarko opened this issue Jun 6, 2016 · 3 comments

Comments

@hozjanmarko
Copy link

I wonder if you could provided typescript definition files for the DefinitelyTyped repo.
I'm currently using my own definitions(https://github.com/hozjanmarko/node-firebird-dts), but it would be very helpfull, if we could get the typings directly through tds(https://github.com/DefinitelyTyped/tsd) or typings(https://github.com/typings/typings).

@calvin
Copy link
Contributor

calvin commented Jul 20, 2016

This is a definition that I wrote: https://gist.github.com/calvin/b4c8df06c898d637e1076d3afafb5ad7.

If possible, I think it is good to be included in the package than pushing the definitions to https://github.com/DefinitelyTyped/DefinitelyTyped

@maintainers Have a look at http://www.typescriptlang.org/docs/handbook/typings-for-npm-packages.html and https://github.com/typings/typings/blob/master/docs/faq.md#should-i-use-the-typings-field-in-packagejson

@mariuz
Copy link
Collaborator

mariuz commented Oct 17, 2017

Please review the one that we added by this pull request
#136

https://github.com/hgourvest/node-firebird/blob/master/index.d.ts

@mariuz mariuz closed this as completed Oct 17, 2017
@hozjanmarko
Copy link
Author

Great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants