Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E306 #295

Merged
merged 6 commits into from Jan 17, 2017
Merged

Add E306 #295

merged 6 commits into from Jan 17, 2017

Conversation

khairihafsham
Copy link
Contributor

#287 PR has failing tests mostly because E305. This PR splits E306 from that.

khairihafsham and others added 5 commits January 15, 2017 17:54
@coveralls
Copy link

coveralls commented Jan 16, 2017 •
edited

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 54ea220 on khairihafsham:add-e306 into 9a311bf on hhatto:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 54ea220 on khairihafsham:add-e306 into 9a311bf on hhatto:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 54ea220 on khairihafsham:add-e306 into 9a311bf on hhatto:master.

@coveralls
Copy link

coveralls commented Jan 16, 2017 •
edited

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 54ea220 on khairihafsham:add-e306 into 9a311bf on hhatto:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 54ea220 on khairihafsham:add-e306 into 9a311bf on hhatto:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 54ea220 on khairihafsham:add-e306 into 9a311bf on hhatto:master.

@myint
Copy link
Collaborator

myint commented Jan 16, 2017

Could you resolve the merge conflict? Thanks.

@khairihafsham
Copy link
Contributor Author

Done 😄

@coveralls
Copy link

coveralls commented Jan 17, 2017 •
edited

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 86c6bcf on khairihafsham:add-e306 into aa92f3b on hhatto:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 86c6bcf on khairihafsham:add-e306 into aa92f3b on hhatto:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 86c6bcf on khairihafsham:add-e306 into aa92f3b on hhatto:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 86c6bcf on khairihafsham:add-e306 into aa92f3b on hhatto:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.311% when pulling 86c6bcf on khairihafsham:add-e306 into aa92f3b on hhatto:master.

@myint myint merged commit f8ea7c1 into hhatto:master Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khairihafsham @coveralls @myint @hhatto