New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for skipping formatting of a block in a file #557
Conversation
Looks like there are failing tests, converting to draft whilst this is worked out. |
@hhatto looks like it was just a rouge print statement and some formatting that pycodestyle did not like, I think its ready for a review now. |
@hhatto I don't suppose you've had a chance to look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change is solid and clean 👍
Thanks for your contribution.
We will release it in version 1.5.4 within a week. |
Great thank you :-)
…On Thu, 23 Jul 2020, 17:03 Hideo Hattori, ***@***.***> wrote:
We will release it in version 1.5.4 within a week.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#557 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFYNL44ILYG63BXYVBPKJLR5BNLFANCNFSM4OYVAHZQ>
.
|
hhatto#557 Added support for this but I forgot to update the readme.
As requested in #460 it would be nice to be able toggle support formatting on and off. It has been implemented as:
or
I am not 100% sure that I have managed to run all of the tests correctly. This needs to be checked before merging.