Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for skipping formatting of a block in a file #557

Merged
merged 10 commits into from Jul 23, 2020

Conversation

shardros
Copy link
Contributor

@shardros shardros commented Jul 13, 2020

As requested in #460 it would be nice to be able toggle support formatting on and off. It has been implemented as:

# autopep8: off
# autopep8: on

or

# fmt: off
# fmt: on

I am not 100% sure that I have managed to run all of the tests correctly. This needs to be checked before merging.

@shardros shardros marked this pull request as draft July 13, 2020 16:39
@shardros
Copy link
Contributor Author

Looks like there are failing tests, converting to draft whilst this is worked out.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.727% when pulling c5d00ab on shardros:on-off into 2ab2ea7 on hhatto:master.

@shardros shardros marked this pull request as ready for review July 14, 2020 08:50
@shardros
Copy link
Contributor Author

@hhatto looks like it was just a rouge print statement and some formatting that pycodestyle did not like, I think its ready for a review now.

@hhatto hhatto self-requested a review July 14, 2020 12:22
@shardros
Copy link
Contributor Author

@hhatto I don't suppose you've had a chance to look at this?

@hhatto hhatto added this to the 1.5.4 milestone Jul 23, 2020
Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This change is solid and clean 👍

Thanks for your contribution.

@hhatto hhatto merged commit e926c98 into hhatto:master Jul 23, 2020
@hhatto
Copy link
Owner

hhatto commented Jul 23, 2020

We will release it in version 1.5.4 within a week.

@shardros
Copy link
Contributor Author

shardros commented Jul 23, 2020 via email

@shardros shardros deleted the on-off branch July 23, 2020 16:08
shardros added a commit to shardros/autopep8 that referenced this pull request Jan 11, 2022
hhatto#557 Added support for this but I forgot to update the readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants