This repository has been archived by the owner on Aug 10, 2022. It is now read-only.
Support grapheme clusters #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senpai now correctly computes the width of unicode strings, such as sequences of emoji interleaved with Zero-Width-Joiners, and the editor goes from cluster to cluster, instead of codepoint (rune) to codepoint. This breaks users on terminal that do not support grapheme clusters, such as alacritty[0]. See http://unicode.org/reports/tr29/ and https://github.com/rivo/uniseg [0] alacritty/alacritty#3975
hhirtz
force-pushed
the
grapheme-clusters
branch
from
75a91c3
to
2ca8e2d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
figure out problems with foot:explanation here https://codeberg.org/dnkl/foot/issues/782#issuecomment-278311Related, maybe?
It seems there is no way to compute the width of a grapheme cluster, so I think the best way to go is to not change the way senpai computes the width of strings (rune by rune), but still tell tcell to render the grapheme cluster as one.
senpai now correctly computes the width of unicode strings, such as
sequences of emoji interleaved with Zero-Width-Joiners, and the editor
goes from cluster to cluster, instead of codepoint (rune) to codepoint.
This breaks users on terminal that do not support grapheme clusters,
such as alacritty[0].
See http://unicode.org/reports/tr29/
and https://github.com/rivo/uniseg
[0] alacritty/alacritty#3975