LPS-71333 NullPointerException when sorted the DM #3221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test |
The pull request tester is still running.Please wait until you get the final report before running 'ci:retest'. See this link to check on the status of your test: However, the pull request was closed.The pull request was closed because the following critical batches had failed:
For information as to why we automatically close out certain pull requests see this article. *This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment. ci:reopen Critical Failure Details:test-portal-acceptance-pullrequest-batch(master)/integration-db2105-jdk8Job Results:3149 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/integration-hypersonic20-jdk8Job Results:3144 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/integration-mariadb100-jdk8Job Results:3143 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/integration-mysql56-jdk8Job Results:3143 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/integration-oracle121-jdk8Job Results:3149 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/integration-postgresql94-jdk8Job Results:3144 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/integration-sybase160-jdk8Job Results:3142 Tests Passed.
|
|
ci:reopen |
liferay-continuous-integration
added
ci:test - failure
and removed
ci:test - pending
labels
|
@daviddotzhang, why is |
|
@hhuijser we are able to use the setResults to make "_result" NULL. while I think we need to fix it in a common way in "SearchContainerResultsTag.java" |
|
It's still a random place to do the fix, since we have many other places where we can have a NPE if So, either we somehow never allow I would rather fix this one by changing the initial value of |
daviddotzhang
force-pushed
the
LPS-71333
branch
from
19a2a2a
to
9e45e15
Compare
|
@hhuijser, I have updated the pull request, also tested blog portlet, which does not have the NPE problem. |
|
Sent to Eudaldo for review: ealonso#1540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.