greatbritishchefs: handle case where ingredients are in subheaders (#598

)
hhursev · Sep 5, 2022 · 9ecaec3 · 9ecaec3
1 parent 348abb2
commit 9ecaec3
Show file tree

Hide file tree

Showing 5 changed files with 2,260 additions and 3 deletions.
diff --git a/recipe_scrapers/greatbritishchefs.py b/recipe_scrapers/greatbritishchefs.py
@@ -49,14 +49,19 @@ def image(self):
         return src if image else None
 
     def ingredients(self):
-        ingredientsOuter = self.soup.find(
+        ingredientsOuter = self.soup.findAll(
             "ul", {"class": "IngredientsList__ListContainer"}
         )
         ingGroup = []
-        ingredparts = ingredientsOuter.findAll("li")
+        ingredparts = []
+
+        for subheader in ingredientsOuter:
+            ingredparts.extend(subheader.findAll("li"))
+
         for i in ingredparts:
             x = normalize_string(i.get_text())
-            ingGroup.append(x)
+            if x != "":  # Some recipes include an empty li
+                ingGroup.append(x)
         return ingGroup
 
     def instructions(self):

diff --git a/tests/test_data/greatbritishchefs.testhtml → tests/test_data/greatbritishchefs_1.testhtml b/tests/test_data/greatbritishchefs.testhtml → tests/test_data/greatbritishchefs_1.testhtml