Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisy ResourceWarning messages appearing during unit tests #608

Closed
jayaddison opened this issue Sep 30, 2022 · 0 comments · Fixed by #609
Closed

Noisy ResourceWarning messages appearing during unit tests #608

jayaddison opened this issue Sep 30, 2022 · 0 comments · Fixed by #609

Comments

@jayaddison
Copy link
Collaborator

As part of #552, the way that test data is loaded was modified and no longer uses a context manager for the file open operation.

We aren't closing the resulting files automatically, and this can cause some noisy ResourceWarning messages to be produced when unit tests run.

(note: these seem to be suppressed by unittest-parallel, so we don't see them in our GitHub Actions console output)

It'd be good to ensure that the files are closed correctly to remove this noise.

jayaddison added a commit that referenced this issue Sep 30, 2022
…loading to avoid noisy ResourceWarning output when running unit tests with python -m unittest

Fixes #608
jayaddison added a commit that referenced this issue Sep 30, 2022
…loading to avoid noisy ResourceWarning output when running unit tests with python -m unittest (#609)

Fixes #608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant