Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random bug fixes #542

Merged
merged 15 commits into from
Oct 31, 2023
Merged

Random bug fixes #542

merged 15 commits into from
Oct 31, 2023

Conversation

lexidor
Copy link
Contributor

@lexidor lexidor commented May 24, 2023 •
edited
Loading

Fixes:

  • NoEmptyStatementsLinter
    • False negative 3 <= 4 was not treated as an empty expression.
    • False negative 3 >= 4 was not treated as an empty expression.
    • Comment: Mentioned ExpressionStament::getOperator(), should have been BinaryOperation.
  • NodeList::getChildrenOfItemsOfType<T>(classname<T> $classname): vec<T>
    • T was not inferred to be the type of the classname argument.
    • Added getChildrenOfItemsByType<reify T>() to match getChildrenByType<reify T>().
    • Comment mentioned NodeList::createEmptyListOrNull(), which doesn't exist anymore.
  • Constants may now appear as the sole expression of a lambda body.
  • Codegen no longer consumes more threads than hardware threads of the machine.

And a quick formatting of the affect files.

@lexidor
Document bug comparison empty statements
a9cc0ab 
The operators `<=` and `>=` should be treated as empty.
They are currently treated as assignments.
@lexidor
Fix false negative, <= and >= in NoEmptyStatementsLinter
d2a9dfc
@lexidor
Document bug NodeList::getChildrenOfItemsOfType() does not refine
14a8fea
@lexidor
Fix type refinement of NodeList::getChildrenOfItemsOfType<T>()
99b1131
@lexidor
Add NodeList::getChildrenOfItemsByType<T>()
f5d4890 
This completes this list:
 - Node->getChildrenOfType<T>()
 - Node->getDescendantsOfType<T>()
 - Node->getFirstDescendantOfType<T>()
 - NodeList->getChildrenOfItemsByType<T>()
@lexidor
Remove reference in comment to createMaybeEmptyList
6641652 
This function does not exist anymore.
@lexidor
Post commit formatting
8176da6
@lexidor
Lint clean
f2bca6d
@yucombinator yucombinator merged commit 2339345 into hhvm:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lexidor @yucombinator @facebook-github-bot