-
Notifications
You must be signed in to change notification settings - Fork 23
Got undeclared identifier 'htonll' when building on Mac OS X 10.9 #4
Comments
Interesting, will look into it later. |
Yeah, it's unclear why this file has its own implementations (maybe there is a good reason, we'll see); we can probably move the one in |
But also curious why this is working on my machine. Maybe something with |
htonll is defined in 10.10 at /usr/include/sys/_endian.h, but not in 10.9. |
Attempted fix is up internally. I don't actually have a 10.9 machine to test with though... |
I tried to patch ext_fb.cpp like what I said, and can be successfully built without other change. :) |
Yeah that's what my internal diff does, more or less :) Running into some infra issues right now, so it might be a couple of days to get it out since I'm in the middle of some travel right now. |
Here's my patch, since it could be a couple of days. If you could confirm this patch fixes the issue, that would actually be really useful since I don't have a 10.9 machine and am just kind of guessing based on what you and @wjywbs said.
|
Summary: We have two, but one is much less featureful than the other, and is also implemented as two 32-bit swaps (when some libc-provided implementations can just use a single asm instruction sometimes). Let's just use one. I *hope* this will also fix the build on OS X 10.9, where `htonll` isn't defined, by standardizing on the macro that actually works there. But I don't have a system to test on. Ref. hhvm/homebrew-hhvm#4 Reviewed By: @paulbiss Differential Revision: D2407062
This should be fixed if you build with |
Looks like need a check similar as in hphp/runtime/base/thrift-buffer.h:39-60 ?
The text was updated successfully, but these errors were encountered: