Bring back public HSL testing #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project is now unique, in that it's usually built in to HHVM, but can be worked on separately. This means it has no dependencies, and can't be tested the same way as other projects. Watchman is needed for the built-in autoloader.
Some locale behavior is non-portable and needs fixing in HHVM itself.
|
@fredemmott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 3887ca5. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Nov 23, 2021
Summary: - one test change: the `fr_FR.UTF8` locale that was used in the test is not valid, and must be `fr_FR.UTF-8`. Some environments (including FB's CI environment) are forgiving about this, others aren't. Test the correct thing - only target nightly builds as now that the HSL is bundled with HHVM, we do not need compatibility with other versions - add dependencies for built-in autoloader and locale tests - update .gitignore - do not test on MacOS for now: str purity/locale support has some portability issues that need to be fixed in HHVM itself Pull Request resolved: hhvm/hsl#164 Test Plan: - public run: https://github.com/fredemmott/hsl/actions/runs/1492315037 - legocastle runs + //hphp/hsl/... buck tests Reviewed By: DavidSnider Differential Revision: D32604271 fbshipit-source-id: f0258b93715d4d81d057f9e7967be2d4530ba8f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fr_FR.UTF8locale that was used in the test is not valid, and must befr_FR.UTF-8. Some environments (including FB's CI environment) are forgiving about this, others aren't. Test the correct thingTest Plan: