This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
Add runtime errors when constructing any element with children declarations or categories #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egories - children declarations are meant to be (and appear to be) parse errors with the new syntax - categories can be fully be replaced with interfaces; let's ban them here in expectation of a hack/parser ban in the future - remove the consistency validation trait: it can't be used even before this diff, but doubly so now that it throws - raising exceptions from the constructor gives clearer traces than from render
fredemmott
changed the title
jjergus
approved these changes
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the new syntax
here in expectation of a hack/parser ban in the future
this diff, but doubly so now that it throws
render