Modernize the README for v4 #304

lexidor · 2021-12-20T18:57:00Z

Fixes #287

azjezz · 2021-12-20T19:08:51Z

README.md

@@ -67,6 +67,19 @@ foreach ($items as $item) {

 In the code, `<ul />` creates a ul with no children. Then we dynamically append children to it for each item in the `$items` list.

+Alternatively, you can pass an array of children to `<ul>...</ul>` instead. This is especially useful when dealing with larger xhp trees where it would be harder to get a variable reference to the `ul`.


Suggested change

Alternatively, you can pass an array of children to `<ul>...</ul>` instead. This is especially useful when dealing with larger xhp trees where it would be harder to get a variable reference to the `ul`.

Alternatively, you can pass a `vec` of children to `<ul>...</ul>` instead. This is especially useful when dealing with larger xhp trees where it would be harder to get a variable reference to the `ul`.

I intentionally used the word array here. Xhp-lib can handle all Hack arrays in hhvm 4.103+ and all legacy arrays in hhvm 4.102-. AnyArray implements XhpChild.

https://github.com/facebook/hhvm/blob/master/hphp/hack/hhi/hackarray.hhi#L19

abstract class AnyArray<<<__RequireDynamic>> +Tk as arraykey, <<__RequireDynamic>> +Tv> implements KeyedContainer<Tk, Tv>, \XHPChild {}

Modernize the README for v4

8e66fdf

Fixes #287

facebook-github-bot added the CLA Signed label Dec 20, 2021

Update use statement

bec7da5

azjezz reviewed Dec 20, 2021

View reviewed changes

fredemmott merged commit 995c2c3 into hhvm:main Mar 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize the README for v4 #304

Modernize the README for v4 #304

lexidor commented Dec 20, 2021

azjezz Dec 20, 2021

lexidor Dec 20, 2021

		@@ -67,6 +67,19 @@ foreach ($items as $item) {

		In the code, `<ul />` creates a ul with no children. Then we dynamically append children to it for each item in the `$items` list.

		Alternatively, you can pass an array of children to `<ul>...</ul>` instead. This is especially useful when dealing with larger xhp trees where it would be harder to get a variable reference to the `ul`.

	Alternatively, you can pass an array of children to `<ul>...</ul>` instead. This is especially useful when dealing with larger xhp trees where it would be harder to get a variable reference to the `ul`.
	Alternatively, you can pass a `vec` of children to `<ul>...</ul>` instead. This is especially useful when dealing with larger xhp trees where it would be harder to get a variable reference to the `ul`.

Modernize the README for v4 #304

Modernize the README for v4 #304

Conversation

lexidor commented Dec 20, 2021

azjezz Dec 20, 2021

Choose a reason for hiding this comment

lexidor Dec 20, 2021

Choose a reason for hiding this comment