Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:support mongodb commit sql with comments #2403

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

linhuih
Copy link
Contributor

@linhuih linhuih commented Nov 23, 2023

function execute_check() add sql filter ,support commit sql with comments

before:
image

after:
image
image

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45d7129) 76.31% compared to head (c130653) 76.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2403   +/-   ##
=======================================
  Coverage   76.31%   76.32%           
=======================================
  Files         115      115           
  Lines       15836    15837    +1     
=======================================
+ Hits        12086    12087    +1     
  Misses       3750     3750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大体 ok ,请 black 一下修一下 CI, 谢谢

@linhuih
Copy link
Contributor Author

linhuih commented Nov 23, 2023

done,please check it again

@LeoQuote LeoQuote merged commit 64e5dbe into hhyo:master Nov 23, 2023
10 checks passed
finovy pushed a commit to finovy/Archery that referenced this pull request Dec 1, 2023
* feat:support mongodb commit sql with comments

* feat:support mongodb commit sql with comments

* fix:black code

---------

Co-authored-by: linhui <linhui@hellotalk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants