Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加可执行命令白名单及放行sp_helptext命令。 #273

Merged
merged 3 commits into from
Jun 16, 2019
Merged

添加可执行命令白名单及放行sp_helptext命令。 #273

merged 3 commits into from
Jun 16, 2019

Conversation

AceAttorney
Copy link
Contributor

#246

本地测试通过,前端展示问题再想想,功能先能用再说

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #273 into master will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage    83.2%   83.21%   +0.01%     
==========================================
  Files          65       65              
  Lines        8251     8257       +6     
==========================================
+ Hits         6865     6871       +6     
  Misses       1386     1386
Impacted Files Coverage Δ
sql/engines/tests.py 99.76% <100%> (ø) ⬆️
sql/engines/mssql.py 84.37% <75%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9e11b...49ce990. Read the comment docs.

sql/engines/mssql.py Outdated Show resolved Hide resolved
sql/engines/mssql.py Outdated Show resolved Hide resolved
@LeoQuote LeoQuote self-requested a review June 14, 2019 10:14
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议按评论修改

@LeoQuote
Copy link
Collaborator

🤦🏽‍♂️ 单元测试又降了,在这里把你的这个用例补一下吧

https://github.com/AceAttorney/Archery/blob/fffd1a5ab0919ff0f4910ed539dc916595dcacec/sql/engines/tests.py#L156

@AceAttorney
Copy link
Contributor Author

😊 嗯,正在家里拉代码

@hhyo hhyo requested a review from LeoQuote June 16, 2019 02:23
@hhyo hhyo merged commit d610084 into hhyo:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants