Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加mongo 查询功能 #332

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Conversation

jackielulu17325
Copy link

@jackielulu17325 jackielulu17325 commented Jul 17, 2019

add mongo.py

关联issue: #282

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #332 into master will increase coverage by 0.18%.
The diff coverage is 86.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #332      +/-   ##
=========================================
+ Coverage   85.01%   85.2%   +0.18%     
=========================================
  Files          66      67       +1     
  Lines        8678    8747      +69     
=========================================
+ Hits         7378    7453      +75     
+ Misses       1300    1294       -6
Impacted Files Coverage Δ
sql/models.py 94.92% <ø> (ø) ⬆️
sql/engines/__init__.py 73.8% <0%> (+18.25%) ⬆️
sql/engines/tests.py 99.77% <100%> (ø) ⬆️
sql/engines/mongo.py 82.25% <82.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b28dc0...e7b2d97. Read the comment docs.

@hhyo
Copy link
Owner

hhyo commented Jul 17, 2019

感谢提交,为了合并代码,还需要你帮忙完善如下信息

@LeoQuote
Copy link
Collaborator

我发现表结构没实现,mongo有表结构吗?

@jackielulu17325
Copy link
Author

jackielulu17325 commented Jul 17, 2019 via email

@LeoQuote
Copy link
Collaborator

可能你还是要返回一个无表结构的假返回,不然可能会报错,你本地试用可用吗?

@jackielulu17325
Copy link
Author

我这边没有报错唉

@LeoQuote
Copy link
Collaborator

@jackielulu17325 我帮你改了一点代码, 加了一些单元测试, 把最新拉到本地再看一下, 应该没啥问题了.
@hhyo 稍等作者确认了再合, 应该问题不大

@LeoQuote LeoQuote self-requested a review July 17, 2019 14:56
@LeoQuote LeoQuote changed the title Archery jackie feat: 增加mongo 查询功能 Jul 17, 2019
@hhyo hhyo merged commit 5b8d6d1 into hhyo:master Jul 17, 2019
@hhyo
Copy link
Owner

hhyo commented Jul 17, 2019

演示环境已更新

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants