Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built with Grav link is not displayed correctly #19

Closed
timinator2020 opened this issue Mar 8, 2022 · 4 comments
Closed

Built with Grav link is not displayed correctly #19

timinator2020 opened this issue Mar 8, 2022 · 4 comments
Assignees

Comments

@timinator2020
Copy link

timinator2020 commented Mar 8, 2022

The text displayed on the bottom of the sidebar is as follows:
Built with <a href="http://getgrav.org">Grav</a> - The Modern Flat File CMS

There is no clickable link, it is displaying the text literally.

If I edit templates/partials/sidebar.html.twig and add |raw to the variable expansion, it works:
<p>{{ 'THEME_LEARN2_BUILT_WITH_GRAV'|t|raw }}</p>

That displays a clickable link:
Built with Grav - The Modern Flat File CMS

I suspect that's a bug, but it's also very possible I have something else configured wrong, thus requiring the use of raw?

Thanks for checking.

@paulhibbitts paulhibbitts self-assigned this Mar 8, 2022
@paulhibbitts
Copy link
Contributor

Hi @timinator2020 , thanks for reporting the issue. It looks like that was missed when the theme was updated for Grav 1.7+, I'll take a look and will post an update in the next few days.

@paulhibbitts
Copy link
Contributor

I've just made a new release of Learn2 with Git Sync theme @timinator2020 , could you please update your installation and test? Thanks, Paul.

@timinator2020
Copy link
Author

Yup, that took care of it. Thanks.

@paulhibbitts
Copy link
Contributor

Great, thanks for testing and reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants