Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of imports in Idea IDE. #3

Closed

Conversation

schernolyas
Copy link
Contributor

fix order of imports in Idea IDE. It Must be equals to Eclipse.

@yrodiere
Copy link
Member

Explanation of the other changes on HipChat:

[10:22 AM] Sergey Chernolyas: @yoann other changes in the PR is fix strings formating
[10:22 AM] Sergey Chernolyas: by default, IDEA put parameters of method in new row.
[10:22 AM] Sergey Chernolyas: Eclipse - not

@Sanne
Copy link
Member

Sanne commented Sep 28, 2017

thanks for the explanation! I'll try it out, then assuming it causes no major unexpected changes I'll merge it.

@schernolyas
Copy link
Contributor Author

incorrect file for merging :(

@Sanne
Copy link
Member

Sanne commented Oct 20, 2017

@schernolyas what do you mean?

@schernolyas
Copy link
Contributor Author

@Sanne I try to merge to file hibernate-oRm.xml but need to file hibernate-oGm.xml

@Sanne
Copy link
Member

Sanne commented Oct 20, 2017

We're aiming at having a unique set of style rules for all Hibernate projects.

So hibernate-orm.xml is fine even for OGM. But also that's why we're very conservative in making changes to these: don't want to break other projects.

@yrodiere
Copy link
Member

@Sanne Please discuss that with us on HipChat, I told @schernolyas the exact opposite a few hours ago...
While we are "aiming" at having a unique set of style rules, we definitely don't have one, in particular (but not only) because most ORM developers use IDEA while most non-ORM developers use Eclipse, which use a different order for imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants