HHH-8068 Suggestion for improvement.

hibernate · Aug 21, 2013 · d0a7a01 · d0a7a01
1 parent 9ee5392
commit d0a7a01
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/tree/ConstructorNode.java b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/tree/ConstructorNode.java
@@ -39,6 +39,7 @@
 import org.hibernate.transform.AliasToBeanConstructorResultTransformer;
 import org.hibernate.transform.ResultTransformer;
 import org.hibernate.transform.Transformers;
+import org.hibernate.type.PrimitiveType;
 import org.hibernate.type.Type;
 
 /**
@@ -184,9 +185,22 @@ private Constructor resolveConstructor(String path) throws SemanticException {
 		catch ( PropertyNotFoundException e ) {
 			// this is the exception returned by ReflectHelper.getConstructor() if it cannot
 			// locate an appropriate constructor
-			throw new DetailedSemanticException( "Unable to locate appropriate constructor on class [" + className + "]", e );
-		}
-	}
+            String formattedMessage = formatMissingContructorExceptionMessage(className);
+			throw new DetailedSemanticException( formattedMessage, e );
+		}
+	}
+
+    private String formatMissingContructorExceptionMessage(String className) {
+        String[] params = new String[constructorArgumentTypes.length];
+        for ( int j = 0; j < constructorArgumentTypes.length; j++ ) {
+            params[j] = constructorArgumentTypes[j] instanceof PrimitiveType ?
+                    ( ( PrimitiveType ) constructorArgumentTypes[j] ).getPrimitiveClass().getName() :
+                    constructorArgumentTypes[j].getReturnedClass().getName();
+        }
+        String formattedList = params.length == 0 ? "no arguments constructor" : StringHelper.join(", ", params);
+        return String.format( "Unable to locate appropriate constructor on class [%s]. Expected types are: %s",
+                className, formattedList );
+    }
 
 	public Constructor getConstructor() {
 		return constructor;