HHH-995 Order.ignoreCase() only works for VARCHAR types, not CHAR types

hibernate · Jan 23, 2013 · f676e1e · f676e1e
1 parent 7dd7ca5
commit f676e1e
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/hibernate-core/src/main/java/org/hibernate/criterion/Order.java b/hibernate-core/src/main/java/org/hibernate/criterion/Order.java
@@ -71,7 +71,14 @@ public String toSqlString(Criteria criteria, CriteriaQuery criteriaQuery)
 		StringBuilder fragment = new StringBuilder();
 		for ( int i=0; i<columns.length; i++ ) {
 			SessionFactoryImplementor factory = criteriaQuery.getFactory();
-			boolean lower = ignoreCase && type.sqlTypes( factory )[i]==Types.VARCHAR;
+			boolean lower = false;
+			if ( ignoreCase ) {
+				int sqlType = type.sqlTypes( factory )[i];
+				lower = sqlType == Types.VARCHAR
+						|| sqlType == Types.CHAR
+						|| sqlType == Types.LONGVARCHAR;
+			}
+
 			if (lower) {
 				fragment.append( factory.getDialect().getLowercaseFunction() )
 					.append('(');