HHH-7610 Add an option to initialize empty components when all the pr… #1080
Conversation
| @@ -176,9 +176,7 @@ public boolean isEqual(final Object x, final Object y) throws HibernateException | |||
| if ( x == y ) { | |||
| return true; | |||
| } | |||
| if ( x == null || y == null ) { | |||
There was a problem hiding this comment.
Shouldn't these changes be considered only when this opt-in setting is enabled? Meaning, to me, I think the setting we add ought to be a gate-keeper between we want the original behavior (default) and we want this new behavior (opt-in).
But as it is, these changed checks for isEqual, isDirty, etc all now happen regardless of whether we opted into the "new behavior"
There was a problem hiding this comment.
Yes, we did that on purpose as we think it is a bug in the current behavior.
With the current behavior, when you persist your entity with an empty embedded and you get it back the embedded is null. So we think in this case, the empty embedded and null should be considered equal.
I can change it if you think it's better to keep the old behavior.
There was a problem hiding this comment.
Ok that makes sense, to make the handling reflexive. I'm ok with keeping this.
Could you please look into the conflicts though. Thanks
There was a problem hiding this comment.
Done. It was a new conflict in AvailableSettings as there were new changes since my last rebase.
…operties are null Note that this commit also changes the semantic of the comparison between a null component and a component with all properties null: they are considered equivalent.
|
Applied this upstream. Thanks Guillaume! |
…operties are null
Note that this commit also changes the semantic of the comparison between a null component
and a component with all properties null: they are considered equivalent.