Add support for @Immutable on attributes #1189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Did you sign the CLA? |
|
Signed. |
| } | ||
|
|
||
| @SuppressWarnings({ "unchecked" }) | ||
| private static <T> MutabilityPlan<T> createMutabiltyPlan(Class<T> type) { |
There was a problem hiding this comment.
Love this idea of extending @Immutable to attributes and interpreting that in terms of MutabilityPlan. One place you missed for that is in org.hibernate.type.descriptor.java.JavaTypeDescriptorRegistry.FallbackJavaTypeDescriptor. Could you add this logic there as well? Thanks
|
I added the HHH-10714 issue for this PR, and I'm going to review it. |
|
Thanks for contributing. I replaced this PR with this one which adds some minor adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add support for @immutable annotation on entity attributes. Benefits: