CUBRID Database Dialect #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okay, please create a jira and also, we need another pull request for the master branch, thanks |
|
Yes. I have already created a JIRA issue https://hibernate.onjira.com/browse/HHH-6577. And I will sent another pull request to master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am the CUBRID open source RDBMS Project Manager. Our parent company NHN has extensively been using Hibernate in its services together with CUBRID Database Server.
I have already communicated with Strong Liu who suggested to provide a patch for the Dialect Resolver. So, I have patched it.
CUBRIDDialect class supports all versions of CUBRID starting from version 8.3.0 (8.3.0, 8.3.1, and current stable 8.4.0).
If there is anything you would like me to change/add, please let me know. I will be glad to work on it.
Regards,
Esen Sagynov.
CUBRID Project Manager.