Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-10654 - LockOptions.SKIP_LOCKED semantics implementation on MSSQL #1859

Merged
merged 1 commit into from Apr 3, 2017
Merged

HHH-10654 - LockOptions.SKIP_LOCKED semantics implementation on MSSQL #1859

merged 1 commit into from Apr 3, 2017

Conversation

vladmihalcea
Copy link
Contributor

@vladmihalcea vladmihalcea requested a review from Naros March 24, 2017 08:03
@vladmihalcea
Copy link
Contributor Author

@Naros Could you please review this Pull Request. It's about the SQL Server lock hints we discussed on HipChat yesterday.

Naros
Naros approved these changes Mar 31, 2017
View reviewed changes
Copy link
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine. I did notice ~17 test failures but they're unrelated to your fix. We can discuss those separately and address them.

@vladmihalcea
Copy link
Contributor Author

Cool. I'll integrate it next week.

@vladmihalcea vladmihalcea merged commit 2a9c0fe into hibernate:master Apr 3, 2017
@vladmihalcea vladmihalcea deleted the HHH-10654 branch April 3, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naros Naros Naros approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
2 participants
@vladmihalcea @Naros