HHH-7910 Transaction timeout can cause non-threadsafe session access by reaper thread #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,8 +51,13 @@ | |||
| private ManagedFlushChecker managedFlushChecker; | |||
| private AfterCompletionAction afterCompletionAction; | |||
| private ExceptionMapper exceptionMapper; | |||
|
|
|||
| private static final int NO_STATUS = -1; | |||
| private long registrationThreadId; | |||
There was a problem hiding this comment.
registrationThreadId can be final I think.
|
@scottmarlow @sebersole Can you re-review? The thread ID is checked on pulse. Delayed action handling occurs only on rollback. Added a setting to completely disable the check. Can you help me rename the setting and its accompanying text? Not happy with it -- writer's block. |
| @@ -119,6 +127,35 @@ private void setRollbackOnly() { | |||
| } | |||
|
|
|||
| public void afterCompletion(int status) { | |||
| if ( !settings.isJtaThreadHandling() || isRegistrationThread() ) { | |||
There was a problem hiding this comment.
Ugh, we should have (re)checked this ;)
Unless I am missing something, don't we miss calling doAfterCompletion (immediately or delayed) when afterCompletion is called with SUCCESS from a "non-main" thread
- the thread checks res
There was a problem hiding this comment.
Damn, good catch. Had that originally -- not sure what happened to it. I'll fix and push in a sec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.