Added patch for HHH-1237 #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nFactory() in documentation
Configuration#buildSessionFactory() in documentation
Serializable class
…rm) XSD; HHH-7556 - Clean up packages; HHH-7164 - Finish out SessionFactoryBuilder api
…EntityClass() before persisters are bound
…emoved isDefaultUseNewMetamodel()
with missing descriptor files. Mojo will automatically hook into build lifecycle compile phase. Conflicts: hibernate-enhance-maven-plugin/src/main/java/org/hibernate/bytecode/enhance/plugins/MavenEnhancePlugin.java settings.gradle tooling/hibernate-maven-plugin/hibernate-maven-plugin.gradle
Conflicts: .gitignore hibernate-enhance-maven-plugin/src/main/resources/META-INF/maven/plugin.xml hibernate-enhance-maven-plugin/src/main/resources/META-INF/maven/plugin.xml.original tooling/hibernate-enhance-maven-plugin/src/main/resources/META-INF/maven/plugin.xml
…is removed by later merge (test case)
of SqlExceptionHelper#handleAndClearWarnings Conflicts: hibernate-core/src/main/java/org/hibernate/engine/jdbc/spi/SqlExceptionHelper.java
A patch for bug "Escaping : with :: in queries" (HHH-1237) was provided three years ago, but never applied to the code: https://hibernate.atlassian.net/browse/HHH-1237 Wasn't able to test it because I don't use Gradle (Maven wouldn't have been a problem...)
|
Thanks @michael-schnell, seems reasonable. @sebersole, what do you think? |
|
Any progress on merging the pull request? |
|
No merge? What's wrong with the patch? Would at least be nice to add some kind of comment... |
|
GitHub automatically closed Pull Requests targetting master when I was doing some moving around of branches. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch for bug "Escaping : with :: in queries" (HHH-1237) was provided three years ago, but never applied to the code: https://hibernate.atlassian.net/browse/HHH-1237
Wasn't able to test it because I don't use Gradle (Maven wouldn't have been a problem...)