Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-15086 Introduce configurable query cache layout #7543

Merged
merged 1 commit into from
Jan 26, 2024
Merged

HHH-15086 Introduce configurable query cache layout #7543

merged 1 commit into from
Jan 26, 2024

Conversation

beikov
Copy link
Contributor

@beikov beikov commented Nov 14, 2023 •
edited by hibernate-github-bot bot
Loading

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 14, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Nov 16, 2023 •
edited
Loading

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@beikov beikov added the 6.5 label Nov 16, 2023
@beikov beikov force-pushed the HHH-15086 branch 7 times, most recently from 0cf03da to 0a63c1e Compare November 23, 2023 10:40
@beikov beikov mentioned this pull request Nov 24, 2023
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 21, 2023
View reviewed changes
...te-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionTest.java Fixed Show fixed Hide fixed
...e-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowMultiselectTest.java Fixed Show fixed Hide fixed
...te-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionTest.java Fixed Show fixed Hide fixed
...e-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowMultiselectTest.java Fixed Show fixed Hide fixed
...te-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionTest.java Fixed Show fixed Hide fixed
...ava/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithDiscriminatorPolymorphicTest.java Fixed Show fixed Hide fixed
...ava/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithDiscriminatorPolymorphicTest.java Fixed Show fixed Hide fixed
...ava/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithDiscriminatorPolymorphicTest.java Fixed Show fixed Hide fixed
...ava/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithDiscriminatorPolymorphicTest.java Fixed Show fixed Hide fixed
.../src/main/java/org/hibernate/metamodel/mapping/internal/DiscriminatedAssociationMapping.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 22, 2023
View reviewed changes
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java Fixed Show fixed Hide fixed
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java Fixed Show fixed Hide fixed
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java Fixed Show fixed Hide fixed
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java Fixed Show fixed Hide fixed
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java Fixed Show fixed Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java Fixed Show fixed Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java Fixed Show fixed Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java Fixed Show fixed Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java Fixed Show fixed Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java Fixed Show fixed Hide fixed
@beikov beikov force-pushed the HHH-15086 branch 2 times, most recently from 8534062 to 46001c2 Compare January 8, 2024 09:03
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2024
View reviewed changes
.../java/org/hibernate/sql/results/graph/collection/internal/AbstractCollectionInitializer.java
);
final CollectionPersister persister = collectionAttributeMapping.getCollectionDescriptor();
// Try to reuse the previous collection key and collection if possible
if ( oldKey != null && persister.getKeyType().isEqual( oldKey.getKey(), collectionKeyValue ) ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionPersister.getKeyType
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/collection/spi/CollectionInitializerProducer.java
Comment on lines +90 to +98
return produceInitializer(
navigablePath,
attribute,
parentAccess,
lockMode,
collectionKeyAssembler,
collectionValueKeyAssembler,
creationState
);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionInitializerProducer.produceInitializer
Loading
should be avoided because it has been deprecated.
.../java/org/hibernate/sql/results/graph/entity/AbstractDiscriminatedEntityResultGraphNode.java
this.fetches = creationState.visitFetches( this );
assert fetches.size() == 2;

discriminatorValueFetch = fetches.get( graphedPart.getDiscriminatorPart() );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
DiscriminatedAssociationModelPart.getDiscriminatorPart
Loading
should be avoided because it has been deprecated.
.../java/org/hibernate/sql/results/graph/entity/AbstractDiscriminatedEntityResultGraphNode.java

@Override
public Fetch findFetch(Fetchable fetchable) {
if ( graphedPart.getDiscriminatorPart() == fetchable ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
DiscriminatedAssociationModelPart.getDiscriminatorPart
Loading
should be avoided because it has been deprecated.
...ate-core/src/main/java/org/hibernate/sql/results/graph/entity/AbstractEntityInitializer.java
getConcreteDescriptor().getEntityName(),
uniqueKeyAttributePath,
rowProcessingState.getEntityUniqueKey(),
getConcreteDescriptor().getPropertyType( uniqueKeyAttributePath ),

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EntityPersister.getPropertyType
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/sql/results/jdbc/spi/JdbcValues.java
void finishRowProcessing(RowProcessingState rowProcessingState);

default void finishRowProcessing(RowProcessingState rowProcessingState, boolean wasAdded) {
finishRowProcessing( rowProcessingState );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
JdbcValues.finishRowProcessing
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/sql/results/jdbc/spi/RowProcessingState.java
* Callback at the end of processing the current "row"
*/
default void finishRowProcessing(boolean wasAdded) {
finishRowProcessing();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
RowProcessingState.finishRowProcessing
Loading
should be avoided because it has been deprecated.
@beikov beikov merged commit 7ef13e1 into hibernate:main Jan 26, 2024
24 checks passed
@beikov beikov deleted the HHH-15086 branch May 22, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beikov