Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with CockroachDB 22.1.9 #1407

Closed
DavideD opened this issue Oct 18, 2022 · 1 comment · Fixed by #1411
Closed

Build fails with CockroachDB 22.1.9 #1407

DavideD opened this issue Oct 18, 2022 · 1 comment · Fixed by #1411
Assignees
Labels
testing Improvements to test suite upgrade Impact of dependency upgrades
Milestone

Comments

@DavideD
Copy link
Member

DavideD commented Oct 18, 2022

Here's an extract of one of the stacktraces:

Gradle Test Executor 7 > org.hibernate.reactive.schema.SchemaUpdateCockroachDBTestBase$IndividuallySchemaUpdateCockroachTestBase > testValidationSucceed PASSED                                                      
                                                                                                                                                                                                                     
Gradle Test Executor 7 > org.hibernate.reactive.schema.SchemaUpdateCockroachDBTestBase$IndividuallySchemaUpdateCockroachTestBase > testUpdate FAILED                                                                 
    java.lang.AssertionError: Not equals : CREATE INDEX i_asimple_avalue_astringvalue ON postgres.public.asimple USING btree (avalue ASC, astringvalue DESC) != CREATE UNIQUE INDEX asimple_pkey ON postgres.public.$
simple USING btree (id ASC)                                                      

A branch with Cockroach already updated is here: https://github.com/DavideD/hibernate-reactive/tree/update-cockroach

DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Oct 18, 2022
@DavideD DavideD added the upgrade Impact of dependency upgrades label Oct 18, 2022
@blafond
Copy link
Member

blafond commented Oct 18, 2022

There are 3 failing assertion checks in SchemaUpdateCockroachDBTestBase.updateTest(...)

From what I can tell, we're sending an index definition SQL to ORM's NativeQueryImpl and it's returning a complete native query that's executed. The returned queries that are failing were expecting a placeholder/id of "primary" and that has now changed and is different for the 3 failing checks.

Changing the expected query strings in the test should be all that is needed

blafond pushed a commit to blafond/hibernate-reactive that referenced this issue Oct 18, 2022
blafond added a commit to blafond/hibernate-reactive that referenced this issue Oct 18, 2022
Signed-off-by: blafond <blafond@redhat.com>
blafond pushed a commit to blafond/hibernate-reactive that referenced this issue Oct 19, 2022
blafond added a commit to blafond/hibernate-reactive that referenced this issue Oct 19, 2022
Signed-off-by: blafond <blafond@redhat.com>
blafond added a commit to blafond/hibernate-reactive that referenced this issue Oct 19, 2022
Signed-off-by: blafond <blafond@redhat.com>
DavideD pushed a commit that referenced this issue Oct 20, 2022
Signed-off-by: blafond <blafond@redhat.com>
@DavideD DavideD added this to the next milestone Oct 20, 2022
@DavideD DavideD added the testing Improvements to test suite label Oct 20, 2022
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Oct 20, 2022
Signed-off-by: blafond <blafond@redhat.com>
@DavideD DavideD modified the milestones: next, 2.0.0.Alpha1 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements to test suite upgrade Impact of dependency upgrades
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants