-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Hibernate ORM to 6.3.0.Final #1734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2023
Closed
public class ReactiveArrayJdbcTypeConstructor implements JdbcTypeConstructor { | ||
public static final ReactiveArrayJdbcTypeConstructor INSTANCE = new ReactiveArrayJdbcTypeConstructor(); | ||
|
||
public JdbcType resolveType( |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
This method overrides ; it is advisable to add an Override annotation.
JdbcTypeConstructor.resolveType
Error loading related location
return new Id<>( attributeName, id ); | ||
} | ||
|
||
public static <T> Id<T> id(Class<T> entityClass, String attributeName, Object id) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
The parameter 'entityClass' is never used.
DavideD
force-pushed
the
2.1
branch
6 times, most recently
from
September 1, 2023 13:31
69eb53b
to
d95e8e4
Compare
DavideD
changed the title
Upgrade Hibernate ORM to 6.3
Upgrade Hibernate ORM to 6.3.0.Final
Sep 1, 2023
This reverts commit fc23d87. Something has changed in Hibrnate ORM 6.3 and the previous fix is not enough anymore
* Fix compilation errors * Add ReactiveArrayJdbcTypeConstructor * Remove duplicated methods from ORM
With ORM 6.3 the boolean converter is mapped as a char. WIth ORM 6.2 it was an enum.
1. fix the broken signature of createSelectionQuery() oops! 2. hibernate#1703 add enableFetchProfile() to Query
also add missing createSelectionQuery()/createMutationQuery() to StatelessSession
A lot of tests fail with the usual error: ``` java.lang.IllegalStateException: Needed to have 6 in buffer but only had 0 ``` This is a known issue with the Vert.x driver. See hibernate#1345
Merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1726
This branch will be merged to
main
after the next Hibernate ORM 6.3 release (we will need to update the properties before releasing it)I've already merged the existing PRs in it, but it needs the latest ORM snapshot to work and it might not be available remotely at the moment (should be available soon).
Fix #1718
Fix #1703
Fix #1706