Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hibernate ORM to 6.3.0.Final #1734

Merged
merged 11 commits into from
Sep 1, 2023
Merged

Upgrade Hibernate ORM to 6.3.0.Final #1734

merged 11 commits into from
Sep 1, 2023

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Aug 29, 2023

Supersedes #1726

This branch will be merged to main after the next Hibernate ORM 6.3 release (we will need to update the properties before releasing it)

I've already merged the existing PRs in it, but it needs the latest ORM snapshot to work and it might not be available remotely at the moment (should be available soon).

Fix #1718
Fix #1703
Fix #1706

public class ReactiveArrayJdbcTypeConstructor implements JdbcTypeConstructor {
public static final ReactiveArrayJdbcTypeConstructor INSTANCE = new ReactiveArrayJdbcTypeConstructor();

public JdbcType resolveType(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
JdbcTypeConstructor.resolveType
; it is advisable to add an Override annotation.
return new Id<>( attributeName, id );
}

public static <T> Id<T> id(Class<T> entityClass, String attributeName, Object id) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'entityClass' is never used.
@DavideD DavideD changed the title Upgrade Hibernate ORM to 6.3 Upgrade Hibernate ORM to 6.3.0.Final Sep 1, 2023
@DavideD DavideD modified the milestone: 2.1.0.Final Sep 1, 2023
DavideD and others added 11 commits September 1, 2023 21:31
This reverts commit fc23d87.

Something has changed in Hibrnate ORM 6.3 and the previous
fix is not enough anymore
* Fix compilation errors
* Add ReactiveArrayJdbcTypeConstructor
* Remove duplicated methods from ORM
With ORM 6.3 the boolean converter is mapped as a char.
WIth ORM 6.2 it was an enum.
1. fix the broken signature of createSelectionQuery() oops!
2. hibernate#1703 add enableFetchProfile() to Query
also add missing createSelectionQuery()/createMutationQuery() to StatelessSession
A lot of tests fail with the usual error:

```
java.lang.IllegalStateException: Needed to have 6 in buffer but only had 0
```

This is a known issue with the Vert.x driver.
See hibernate#1345
@DavideD DavideD merged commit c1afdb5 into hibernate:main Sep 1, 2023
20 checks passed
@DavideD
Copy link
Member Author

DavideD commented Sep 1, 2023

Merged in main

@DavideD DavideD added this to the 2.1.0.Final milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Hibernate ORM to 6.3.0.Final add support for Page in Query add enableFetchProfile() to Query
2 participants