Skip to content

Commit

Permalink
HSEARCH-2012 Improve logging and default implementations
Browse files Browse the repository at this point in the history
  • Loading branch information
Sanne committed Dec 17, 2015
1 parent 17412a6 commit a871c69
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@ public void closeIndexWriter() {
if ( selectionStrategy.isIndexOwnerLocal() ) {
delegatedBackend.closeIndexWriter();
}
else {
log.debugf( "Not owning the index '%s' so ignoring request to release IndexWriter lock", indexName );
}
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ public void indexMappingChanged() {

@Override
public void closeIndexWriter() {
throw new UnsupportedOperationException();
// no-op
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ public LuceneWorkSerializer getSerializer() {

@Override
public void closeIndexWriter() {
throw new UnsupportedOperationException( "Access to IndexWriter not supported with ES IndexManager" );
// no-op
}

private SerializationProvider requestSerializationProvider() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void indexMappingChanged() {

@Override
public void closeIndexWriter() {
log.debug( "Closing IndexWriter" );
log.debug( "BlackHoleBackend requested to close the IndexWriter (no-op)" );
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,6 @@ public interface Log extends BasicLogger {
+ "indexing backend for index '%s'. Some pending index writes might have been lost.")
void timedOutWaitingShutdown(String indexName);


@LogMessage(level = Level.DEBUG)
@Message(id = 304, value = "Closing index writer for IndexManager '%1$s'")
void closingIndexWriter(String indexName);
Expand Down

0 comments on commit a871c69

Please sign in to comment.