Skip to content

Commit

Permalink
HSEARCH-2541 Make protected some methods that have no business being …
Browse files Browse the repository at this point in the history
…public
  • Loading branch information
yrodiere committed Mar 6, 2017
1 parent 3a0493a commit df590b9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public Object loadWithoutTiming(EntityInfo entityInfo) {
return executeLoad( entityInfo );
}

public abstract Object executeLoad(EntityInfo entityInfo);
protected abstract Object executeLoad(EntityInfo entityInfo);

@Override
public List load(List<EntityInfo> entityInfos) {
Expand All @@ -63,7 +63,7 @@ public List load(List<EntityInfo> entityInfos) {
return loadedObjects;
}

public abstract List executeLoad(List<EntityInfo> entityInfo);
protected abstract List executeLoad(List<EntityInfo> entityInfo);
}


Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ public void setEntityTypes(Set<Class<?>> entityTypes) {
}

@Override
public Object executeLoad(EntityInfo entityInfo) {
protected Object executeLoad(EntityInfo entityInfo) {
final Object result = ObjectLoaderHelper.load( entityInfo, session );
timeoutManager.isTimedOut();
return result;
}

@Override
public List executeLoad(List<EntityInfo> entityInfos) {
protected List executeLoad(List<EntityInfo> entityInfos) {
if ( entityInfos.isEmpty() ) {
return Collections.EMPTY_LIST;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void setEntityType(Class entityType) {
}

@Override
public final Object executeLoad(EntityInfo entityInfo) {
protected final Object executeLoad(EntityInfo entityInfo) {
//if explicit criteria, make sure to use it to load the objects
if ( isExplicitCriteria ) {
executeLoad( Collections.singletonList( entityInfo ) );
Expand All @@ -68,7 +68,7 @@ public final Object executeLoad(EntityInfo entityInfo) {
}

@Override
public final List executeLoad(List<EntityInfo> entityInfos) {
protected final List executeLoad(List<EntityInfo> entityInfos) {
if ( entityType == null ) {
throw new AssertionFailure( "EntityType not defined" );
}
Expand Down

0 comments on commit df590b9

Please sign in to comment.