HSEARCH-3493 Test compatibility with JDK13 #1897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same place We don't need to cope with the backward incompatibility between version 2 and 5 of the plugin anymore, so let's simplify this.
…sfile build Elasticsearch 6 doesn't work with JDK13 yet, and ES5 probably never will.
|
Note the build only failed because of AWS support, which isn't implemented yet. So everything is fine. |
Pull Request Test Coverage Report for Build 2
💛 - Coveralls |
fax4ever
approved these changes
Feb 25, 2019
|
Rebased and merged thanks |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net//browse/HSEARCH-3493
I only had to submit a PR to the elasticsearch-maven-plugin so that we can run Elasticsearch with a different JDK. Fortunately it was accepted and released right away, so here is a fully compatible build: everything else already worked.
I'll start a full build soon to demonstrate that it works.=> Done, see here: http://ci.hibernate.org/blue/organizations/jenkins/hibernate-search/detail/PR-1897/2/pipelineFor now, I'd rather keep the JDK13 as experimental (= not run on master) and run a separate weekly job to check compatibility, because I expect most of the breaking changes in JDK13 are still to come.