HSEARCH-3467 Add tests for all the attributes validated by the Elasticsearch schema validator

[fax4ever]

https://hibernate.atlassian.net/browse/HSEARCH-3467

Still in preview, since several attributes have not been tested yet: done

1. Property type attributes: boots removed!, store, null_value, fielddata, doc_values, normalizer done!.
2. Normalizer definition attributes: char_filter, token_filter. already exists
3. Analyzer definition attributes: char_filter, token_filter, tokenizer. already exists

[coveralls]

Pull Request Test Coverage Report for Build 7

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• 5 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.003%) to 88.588%

---

Files with Coverage Reduction	New Missed Lines	%
backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaValidatorImpl.java	5	85.56%

Totals
Change from base Build 219:	0.003%
Covered Lines:	16970
Relevant Lines:	19156

---

💛 - Coveralls

[yrodiere]

Looks good so far. I don't really understand why you changed the structure of the tests, but I guess you have your reasons.

Be careful about validation of analysis definitions, though: some (all?) of it is already addressed in separate tests:

• org.hibernate.search.integrationtest.backend.elasticsearch.management.ElasticsearchNormalizerDefinitionValidationIT
• org.hibernate.search.integrationtest.backend.elasticsearch.management.ElasticsearchAnalyzerDefinitionValidationIT

[fax4ever]

@yrodiere thank you for the review.
I ran this build: http://ci.hibernate.org/view/Search/job/hibernate-search/job/PR-1953/5/parameters/
to check the behavior for all supported ES versions.

[yrodiere]

I added a few comments; most of them are just nitpicking so feel free to ignore if you disagree, but the ones about fielddata and docvalues are, I think, important.

[fax4ever]

Thanks @yrodiere. I think I've addressed the points here.
I started an new full built: http://ci.hibernate.org/job/hibernate-search/view/change-requests/job/PR-1953/7.

[yrodiere]

Merged, thanks!

[fax4ever]

Thanks @yrodiere. I'm reviewing yours.