Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSEARCH-3559 Fix obsolete hibernate.search.indexes.<index name> syntax in the documentation #1957

Merged
merged 3 commits into from
Apr 17, 2019
Merged

HSEARCH-3559 Fix obsolete hibernate.search.indexes.<index name> syntax in the documentation #1957

merged 3 commits into from
Apr 17, 2019

Conversation

yrodiere
Copy link
Member

@coveralls
Copy link

coveralls commented Apr 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 3

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.572%
Totals Coverage Status
Change from base Build 213: 0.0%
Covered Lines: 16726
Relevant Lines: 18884
💛 - Coveralls

@gsmet
Copy link
Member

gsmet commented Apr 16, 2019

Did you document how to affect an entity to a given backend?

@yrodiere
Copy link
Member Author

Did you document how to affect an entity to a given backend?

I had not, since @Indexed was not documented.

Added two commits to document @Indexed.

gsmet
gsmet previously requested changes Apr 17, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment. Otherwise it looks good.

documentation/src/main/asciidoc/mapper-orm-mapping.asciidoc Outdated Show resolved Hide resolved
@yrodiere yrodiere dismissed gsmet’s stale review April 17, 2019 11:47

Done. Waiting for CI and I'll merge.

@yrodiere yrodiere merged commit 50cc781 into hibernate:master Apr 17, 2019
@yrodiere
Copy link
Member Author

Merged, thanks!

@yrodiere yrodiere deleted the HSEARCH-3559 branch April 30, 2019 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yrodiere @coveralls @gsmet