Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSEARCH-3418 Document that Instants are truncated to the millisecond when indexed #2176

Merged
merged 2 commits into from Dec 18, 2019

Conversation

yrodiere
Copy link
Member

@fax4ever fax4ever self-requested a review December 18, 2019 12:18
@fax4ever fax4ever self-assigned this Dec 18, 2019
Copy link
Contributor

@fax4ever fax4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the exact same limitation for both backends?
I have just a comment.

|java.time.MonthDay|-|-|`MonthDay.parse(String)`
|java.util.UUID|`toString()` as a `java.lang.String`|-|`UUID.fromString(String)`
|java.util.Calendar
|A `java.time.ZonedDateTime` representing the same date/time and timezone; see <<mapper-orm-legacy-date-time-apis>>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can put the <<mapper-orm-legacy-date-time-apis>>s under the limitations column.

@yrodiere
Copy link
Member Author

Yes, the limitations are currently the same. I am not sure it will stay that way, though, so I'd rather document them separately. It's not like many people will need to use both backends anyway ;)

I addressed your comment and rebased. Will merge as soon as CI goes green.

@yrodiere yrodiere merged commit 8c65c30 into hibernate:master Dec 18, 2019
@yrodiere yrodiere deleted the HSEARCH-3418 branch January 29, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants