Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSEARCH-3849 Create-or-validate schema management by default #2231

Merged
merged 14 commits into from
Mar 6, 2020
Merged

HSEARCH-3849 Create-or-validate schema management by default #2231

merged 14 commits into from
Mar 6, 2020

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Mar 3, 2020

https://hibernate.atlassian.net/browse/HSEARCH-3849

Based on #2230, which should be merged first.

@yrodiere yrodiere added the Waiting for other pull request Based on another PR that should be merged first label Mar 3, 2020
@fax4ever fax4ever self-assigned this Mar 5, 2020
fax4ever
fax4ever reviewed Mar 5, 2020
View reviewed changes
Copy link
Contributor

@fax4ever fax4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment.
+1 to merge it as well

...ain/java/org/hibernate/search/mapper/orm/schema/management/SchemaManagementStrategyName.java Show resolved Hide resolved
@yrodiere yrodiere added +1 just push it! and removed Waiting for other pull request Based on another PR that should be merged first labels Mar 5, 2020
@yrodiere yrodiere force-pushed the HSEARCH-3849 branch 2 times, most recently from e06202c to 0b3d33e Compare March 6, 2020 07:56
@yrodiere
HSEARCH-3849 Add an SPI for the create-or-validate schema management …
826753a 
…operation
@yrodiere
HSEARCH-3849 Implement the create-or-validate operation in the stub b…
5188f3d 
…ackend
@yrodiere
HSEARCH-3849 Implement the create-or-validate operation for Elasticse…
0d8d2cc 
…arch
@yrodiere
HSEARCH-3849 Test the create-or-validate operation with Elasticsearch
78806cf
@yrodiere
HSEARCH-3849 Implement the create-or-validate operation for Lucene
7f2c6a3
@yrodiere
HSEARCH-3759 Test the create-or-validate operation with Lucene
15a4ec2
@yrodiere
HSEARCH-3849 Add a create-or-validate operation to the POJO schema ma…
902635a 
…nager
@yrodiere
HSEARCH-3849 Add a create-or-validate schema management strategy to t…
55dad66 
…he ORM mapper
@yrodiere
HSEARCH-3849 Test the create-or-validate schema management strategy i…
bc200b1 
…n the ORM mapper
@yrodiere
HSEARCH-3849 Document the create-or-validate Hibernate ORM schema man…
5b05494 
…agement strategy
@yrodiere
HSEARCH-3849 Add a create-or-validate operation to the schema manager…
3e2d37a 
… API in the ORM mapper
@yrodiere
HSEARCH-3849 Test the create-or-validate operation in the schema mana…
dd599b0 
…ger API of the ORM mapper
@yrodiere
HSEARCH-3849 Document the create-or-validate operation in the schema …
bb08f74 
…manager API of the ORM mapper
@yrodiere
HSEARCH-3849 Make the create-or-validate strategy the default
279f23e
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@yrodiere yrodiere merged commit 7c2f91f into hibernate:master Mar 6, 2020
@yrodiere
Copy link
Member Author

yrodiere commented Mar 6, 2020

Merged, thanks!

@yrodiere yrodiere deleted the HSEARCH-3849 branch April 16, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fax4ever fax4ever fax4ever left review comments

Assignees

@fax4ever fax4ever

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yrodiere @fax4ever