HSEARCH-1927 + HSEARCH-1929 Aggregations on multi-valued numeric fields for the Lucene backend #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relied on scores to pass the replacement for missing values, but we just don't need that, since missing values are handled correctly in the FieldComparators. See also 95777b9
…r aggregations 1. This is not the purpose of this ticket, so this should be done as a second step. 2. We know that we will not be able to implement this for Elasticsearch, so we cannot expose this in common APIs, but should expose it in Lucene-specific APIs instead.
…n of doc values retrieval in nested documents
yrodiere
force-pushed
the
HSEARCH-1929
branch
2 times, most recently
from
82cb96c
to
fe05780
Compare
…es accessors in the Lucene backend 1. To avoid hacks where sub-classes of NumericDocValues can actually provide multiple values, in complete opposition to the purpose of the NumericDocValues interface. 2. To avoid instantiation of one lists per document followed by a sort when iterating over the doc values for aggregations. Aggregations can iterate over millions of documents, so this instantiation and sort can actually become a big deal performance-wise.
…tions It's less code, and we don't need more at the moment. We can always revert this commit if one day we need more.
…er term/range This solution is probably not great performance-wise, but at least it will work. It'll have to do until someone has time to find something better.
…ble numeric fields
…ator It's simpler to use.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@yrodiere great work nothing to say about it, merged. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on code extracted from #2255 by @wklaczynski , with a bit of clean-up and a few fixes.