Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSEARCH-4002 + HSEARCH-4003 + HSEARCH-4004 MappingAnnotatedElement improvements #2352

Merged
merged 5 commits into from
Sep 11, 2020
Merged

HSEARCH-4002 + HSEARCH-4003 + HSEARCH-4004 MappingAnnotatedElement improvements #2352

merged 5 commits into from
Sep 11, 2020

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Sep 9, 2020 •
edited
Loading

  • HSEARCH-4003: Automatically expand repeatable annotations in MappingAnnotatedElement
  • HSEARCH-4002: Expose the type of a property for a given ContainerExtractorPath in MappingAnnotatedProperty
  • HSEARCH-4004: Expose an eventContext from MappingAnnotationProcessorContext

Necessary for the Search 5 compatibility layer.

@yrodiere yrodiere changed the title HSEARCH-4002 + HSEARCH-4003 MappingAnnotatedElement improvements HSEARCH-4002 + HSEARCH-4003 + HSEARCH-4004 MappingAnnotatedElement improvements Sep 9, 2020
@yrodiere
Copy link
Member Author

yrodiere commented Sep 9, 2020

Jenkins, retest this please

@fax4ever fax4ever self-assigned this Sep 10, 2020
fax4ever
fax4ever reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@fax4ever fax4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Just 2 not critical comments.

...te/search/mapper/pojo/mapping/definition/annotation/processing/MappingAnnotatedProperty.java Outdated Show resolved Hide resolved
...iontest/mapper/pojo/mapping/annotation/processing/CustomPropertyMappingAnnotationBaseIT.java Outdated Show resolved Hide resolved
@yrodiere
Copy link
Member Author

yrodiere commented Sep 11, 2020 •
edited
Loading

Thanks. Addressed your comments and force-pushed.

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yrodiere yrodiere merged commit 19ac26a into hibernate:master Sep 11, 2020
@yrodiere
Copy link
Member Author

Merged, thanks

@yrodiere yrodiere deleted the HSEARCH-4002 branch September 28, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fax4ever fax4ever fax4ever left review comments

Assignees

@fax4ever fax4ever

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yrodiere @fax4ever