HSEARCH-1242 #373
Merged
HSEARCH-1242 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Prefix used to generate field names for a default {@link Spatial} annotation | ||
| */ | ||
| public static final String COORDINATES_DEFAULT_FIELD = "_hibernate_default_coordinates"; |
There was a problem hiding this comment.
Should we not use something along the lines: __HSearch_Default_Coordinates to align with the names we have in ProjectionConstants?
There was a problem hiding this comment.
You mean for the constant field name or it's value?
But you can't project this as it's just a prefix.
There was a problem hiding this comment.
The field name. I know you cannot project on it, but I think it would be nice if generate field names are somehow aligned. Looks nicer and is more consistent when I look at the index/docment
|
@hferentschik re-pushed |
| /** | ||
| * @experimental This API might change in minor versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.onjira.com/browse/HSEARCH-1242
This is about simplifying usage of the @spatial annotation for those cases in which the Coordinates name is not specified.
Not much changed in the docs yet as there is a specific issue for that.