Updating poms and distribution bundles #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Sanne
commented
Mar 26, 2014
Sanne
commented
- https://hibernate.atlassian.net/browse/HSEARCH-1569
- https://hibernate.atlassian.net/browse/HSEARCH-1570
… and add missing hibernate-search-serialization-java
| @@ -39,14 +39,12 @@ | |||
|
|
|||
| <dependencies> | |||
| <dependency> | |||
| <groupId>${project.groupId}</groupId> | |||
| <groupId>org.hibernate</groupId> | |||
There was a problem hiding this comment.
OOI, why not project.groupId ?
There was a problem hiding this comment.
I just felt the variable injectioni is a bit over-engineered there, and not providing anything of value :)
We'll not change the groupid, and if we ever do it's no big deal to change these.
I just like it to be explicit? Happy to revert if you don't like it but would be curious to know why not.
There was a problem hiding this comment.
I am fine with it. I was really just wondering. No strong feelings one way or the other
|
Looks good. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.