HV-376: Use Character class methods instead of regex categories.

hibernate-validator/src/main/java/org/hibernate/validator/engine/PathImpl.java

@@ -44,7 +44,7 @@ public final class PathImpl implements Path, Serializable {
 	 *
 	 * @see <a href="http://www.regexplanet.com/simple/index.jsp">Regular expression tester</a>
 	 */
-	private static final Pattern PATH_PATTERN = Pattern.compile( "(\\p{javaJavaIdentifierStart}\\p{javaJavaIdentifierPart}*)(\\[(\\w*)\\])?(\\.(.*))*" );
+	private static final Pattern PATH_PATTERN = Pattern.compile( "([^\\[\\.]+)(\\[(\\w*)\\])?(\\.(.*))*" );
 	private static final int PROPERTY_NAME_GROUP = 1;
 	private static final int INDEXED_GROUP = 2;
 	private static final int INDEX_GROUP = 3;
@@ -285,8 +285,12 @@ private static PathImpl parseProperty(String property) {
 			Matcher matcher = PATH_PATTERN.matcher( tmp );
 			if ( matcher.matches() ) {
 
-				// create the node
 				String value = matcher.group( PROPERTY_NAME_GROUP );
+				if ( !isValidJavaIdentifier( value ) ) {
+					throw new IllegalArgumentException( value + " is not a valid Java Identifier" );
+				}
+
+				// create the node
 				path.addNode( value );
 
 				// is the node indexable
@@ -320,4 +324,32 @@ private static PathImpl parseProperty(String property) {
 
 		return path;
 	}
+
+	/**
+	 * Validate that the given identifier is a valid Java identifier according to the Java Language Specification,
+	 * <a href="http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8">chapter 3.8</a>
+	 *
+	 * @param identifier the identifier string
+	 * @return true if the given identifier is a valid Java Identifier
+	 *
+	 * @throws IllegalArgumentException if the identifier is null
+	 */
+	private static boolean isValidJavaIdentifier(String identifier) {
+		Contracts.assertNotNull( identifier, "identifier param cannot be null" );
+
+		final char[] identifierChars = identifier.toCharArray();
+
+		if ( identifierChars.length == 0 || !Character.isJavaIdentifierStart( (int) identifierChars[0] ) ) {
+			return false;
+		}
+
+		for ( int i = 1; i < identifierChars.length; i++ ) {
+			if ( !Character.isJavaIdentifierPart( (int) identifierChars[i] ) ) {
+				return false;
+			}
+		}
+
+		return true;
+	}
+
 }