Skip to content

Commit

Permalink
HV-1463 Make the scripting API an SPI
Browse files Browse the repository at this point in the history
  • Loading branch information
gsmet committed Oct 18, 2017
1 parent 7058f42 commit 9dea2e1
Show file tree
Hide file tree
Showing 26 changed files with 50 additions and 51 deletions.
@@ -1,7 +1,7 @@
package org.hibernate.validator.referenceguide.chapter09;

import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* @author Marko Bekhta
Expand Down
Expand Up @@ -5,9 +5,9 @@

import java.util.Map;

import org.hibernate.validator.scripting.AbstractCachingScriptEvaluatorFactory;
import org.hibernate.validator.scripting.ScriptEvaluationException;
import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.AbstractCachingScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluationException;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.springframework.expression.EvaluationContext;
import org.springframework.expression.EvaluationException;
import org.springframework.expression.Expression;
Expand Down
1 change: 0 additions & 1 deletion engine/pom.xml
Expand Up @@ -238,7 +238,6 @@
org.hibernate.validator.parameternameprovider;version="${project.version}",
org.hibernate.validator.path;version="${project.version}",
org.hibernate.validator.resourceloading;version="${project.version}",
org.hibernate.validator.scripting.*;version="${project.version}",
org.hibernate.validator.spi.*;version="${project.version}"
</Export-Package>
</instructions>
Expand Down
Expand Up @@ -13,11 +13,11 @@
import javax.validation.valueextraction.ValueExtractor;

import org.hibernate.validator.cfg.ConstraintMapping;
import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.constraints.ParameterScriptAssert;
import org.hibernate.validator.constraints.ScriptAssert;
import org.hibernate.validator.spi.resourceloading.ResourceBundleLocator;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* Uniquely identifies Hibernate Validator in the Bean Validation bootstrap
Expand Down
Expand Up @@ -9,10 +9,10 @@

import javax.validation.ValidatorFactory;

import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.constraints.ParameterScriptAssert;
import org.hibernate.validator.constraints.ScriptAssert;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* Provides Hibernate Validator extensions to {@link ValidatorFactory}.
Expand Down
Expand Up @@ -8,9 +8,9 @@

import javax.validation.ConstraintValidatorContext;

import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.scripting.ScriptEvaluatorNotFoundException;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorNotFoundException;

/**
* A custom {@link ConstraintValidatorContext} which allows to set additional message parameters for
Expand Down
Expand Up @@ -11,11 +11,11 @@
import javax.validation.ConstraintValidator;
import javax.validation.ConstraintValidatorContext;

import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.constraintvalidation.HibernateConstraintValidatorContext;
import org.hibernate.validator.internal.util.logging.Log;
import org.hibernate.validator.internal.util.logging.LoggerFactory;
import org.hibernate.validator.scripting.ScriptEvaluatorNotFoundException;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorNotFoundException;

/**
* @author Marko Bekhta
Expand Down
Expand Up @@ -12,8 +12,8 @@

import org.hibernate.validator.internal.util.logging.Log;
import org.hibernate.validator.internal.util.logging.LoggerFactory;
import org.hibernate.validator.scripting.ScriptEvaluationException;
import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluationException;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;

/**
* Context used by validator implementations dealing with script expressions. Instances are thread-safe and can be re-used
Expand Down
Expand Up @@ -51,8 +51,8 @@
import org.hibernate.validator.internal.xml.ValidationXmlParser;
import org.hibernate.validator.messageinterpolation.ResourceBundleMessageInterpolator;
import org.hibernate.validator.resourceloading.PlatformResourceBundleLocator;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.spi.resourceloading.ResourceBundleLocator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* Hibernate specific {@code Configuration} implementation.
Expand Down
Expand Up @@ -27,7 +27,6 @@
import javax.validation.ValidationException;
import javax.validation.metadata.ConstraintDescriptor;

import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.internal.engine.constraintvalidation.ConstraintValidatorContextImpl;
import org.hibernate.validator.internal.engine.constraintvalidation.ConstraintValidatorManager;
import org.hibernate.validator.internal.engine.constraintvalidation.ConstraintViolationCreationContext;
Expand All @@ -38,6 +37,7 @@
import org.hibernate.validator.internal.util.ExecutableParameterNameProvider;
import org.hibernate.validator.internal.util.logging.Log;
import org.hibernate.validator.internal.util.logging.LoggerFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* Context object keeping track of all required data for a validation call.
Expand Down
Expand Up @@ -18,12 +18,12 @@
import javax.validation.valueextraction.ValueExtractor;

import org.hibernate.validator.HibernateValidatorContext;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.internal.engine.valueextraction.ValueExtractorDescriptor;
import org.hibernate.validator.internal.engine.valueextraction.ValueExtractorManager;
import org.hibernate.validator.internal.util.ExecutableParameterNameProvider;
import org.hibernate.validator.internal.util.logging.Log;
import org.hibernate.validator.internal.util.logging.LoggerFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* @author Emmanuel Bernard
Expand Down
Expand Up @@ -54,8 +54,8 @@
import org.hibernate.validator.internal.util.privilegedactions.NewInstance;
import org.hibernate.validator.internal.util.stereotypes.Immutable;
import org.hibernate.validator.internal.util.stereotypes.ThreadSafe;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.spi.cfg.ConstraintMappingContributor;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* Factory returning initialized {@code Validator} instances. This is the Hibernate Validator default
Expand Down
Expand Up @@ -36,7 +36,6 @@
import javax.validation.metadata.BeanDescriptor;
import javax.validation.valueextraction.ValueExtractor;

import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.internal.engine.ValidationContext.ValidationContextBuilder;
import org.hibernate.validator.internal.engine.constraintvalidation.ConstraintValidatorManager;
import org.hibernate.validator.internal.engine.groups.Group;
Expand Down Expand Up @@ -72,6 +71,7 @@
import org.hibernate.validator.internal.util.TypeHelper;
import org.hibernate.validator.internal.util.logging.Log;
import org.hibernate.validator.internal.util.logging.LoggerFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* The main Bean Validation class. This is the core processing class of Hibernate Validator.
Expand Down
Expand Up @@ -32,8 +32,8 @@
import org.hibernate.validator.internal.util.Contracts;
import org.hibernate.validator.internal.util.logging.Log;
import org.hibernate.validator.internal.util.logging.LoggerFactory;
import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* @author Hardy Ferentschik
Expand Down
Expand Up @@ -15,10 +15,10 @@
import org.hibernate.validator.internal.util.logging.Log;
import org.hibernate.validator.internal.util.logging.LoggerFactory;
import org.hibernate.validator.internal.util.privilegedactions.GetClassLoader;
import org.hibernate.validator.scripting.AbstractCachingScriptEvaluatorFactory;
import org.hibernate.validator.scripting.ScriptEngineScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluationException;
import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.AbstractCachingScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEngineScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluationException;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;

/**
* Factory responsible for the creation of JSR 223 based {@link ScriptEngineScriptEvaluator}s. This
Expand Down
Expand Up @@ -41,9 +41,6 @@
import javax.validation.valueextraction.ValueExtractorDefinitionException;
import javax.xml.stream.XMLStreamException;

import org.hibernate.validator.scripting.ScriptEvaluationException;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.scripting.ScriptEvaluatorNotFoundException;
import org.hibernate.validator.internal.engine.messageinterpolation.parser.MessageDescriptorFormatException;
import org.hibernate.validator.internal.metadata.descriptor.ConstraintDescriptorImpl.ConstraintType;
import org.hibernate.validator.internal.metadata.location.ConstraintLocation;
Expand All @@ -53,6 +50,9 @@
import org.hibernate.validator.internal.util.logging.formatter.ExecutableFormatter;
import org.hibernate.validator.internal.util.logging.formatter.TypeFormatter;
import org.hibernate.validator.internal.xml.ContainerElementTypePath;
import org.hibernate.validator.spi.scripting.ScriptEvaluationException;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorNotFoundException;
import org.jboss.logging.BasicLogger;
import org.jboss.logging.annotations.Cause;
import org.jboss.logging.annotations.FormatWith;
Expand Down
Expand Up @@ -4,7 +4,7 @@
* License: Apache License, Version 2.0
* See the license.txt file in the root directory or <http://www.apache.org/licenses/LICENSE-2.0>.
*/
package org.hibernate.validator.scripting;
package org.hibernate.validator.spi.scripting;

import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
Expand Down
Expand Up @@ -4,7 +4,7 @@
* License: Apache License, Version 2.0
* See the license.txt file in the root directory or <http://www.apache.org/licenses/LICENSE-2.0>.
*/
package org.hibernate.validator.scripting;
package org.hibernate.validator.spi.scripting;

import java.util.Map;

Expand Down
Expand Up @@ -4,7 +4,7 @@
* License: Apache License, Version 2.0
* See the license.txt file in the root directory or <http://www.apache.org/licenses/LICENSE-2.0>.
*/
package org.hibernate.validator.scripting;
package org.hibernate.validator.spi.scripting;

import javax.validation.ValidationException;

Expand Down
Expand Up @@ -4,7 +4,7 @@
* License: Apache License, Version 2.0
* See the license.txt file in the root directory or <http://www.apache.org/licenses/LICENSE-2.0>.
*/
package org.hibernate.validator.scripting;
package org.hibernate.validator.spi.scripting;

import java.util.Map;

Expand Down
Expand Up @@ -4,7 +4,7 @@
* License: Apache License, Version 2.0
* See the license.txt file in the root directory or <http://www.apache.org/licenses/LICENSE-2.0>.
*/
package org.hibernate.validator.scripting;
package org.hibernate.validator.spi.scripting;

import javax.validation.ValidatorFactory;

Expand Down
Expand Up @@ -4,7 +4,7 @@
* License: Apache License, Version 2.0
* See the license.txt file in the root directory or <http://www.apache.org/licenses/LICENSE-2.0>.
*/
package org.hibernate.validator.scripting;
package org.hibernate.validator.spi.scripting;

import javax.validation.ValidationException;

Expand Down
Expand Up @@ -8,8 +8,8 @@
/**
* <p>This package provides support for customization of script evaluation in {@code ScriptAssert}
* and {@code ParameterScriptAssert} constraints.</p>
* <p>This package is part of the public Hibernate Validator API.</p>
* <p>This package is part of the public Hibernate Validator SPI.</p>
*
* @author Marko Bekhta
*/
package org.hibernate.validator.scripting;
package org.hibernate.validator.spi.scripting;
Expand Up @@ -6,8 +6,8 @@
*/
package org.hibernate.validator.test.internal.xml;

import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* @author Marko Bekhta
Expand Down
Expand Up @@ -9,11 +9,11 @@
import javax.script.ScriptEngine;
import javax.script.ScriptEngineManager;

import org.hibernate.validator.scripting.AbstractCachingScriptEvaluatorFactory;
import org.hibernate.validator.scripting.ScriptEngineScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluationException;
import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.AbstractCachingScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEngineScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluationException;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;

/**
* {@link ScriptEvaluatorFactory} that allows you to pass multiple {@link ClassLoader}s that will be used
Expand Down
Expand Up @@ -22,11 +22,11 @@
import javax.script.ScriptEngineManager;
import javax.validation.ValidationException;

import org.hibernate.validator.scripting.AbstractCachingScriptEvaluatorFactory;
import org.hibernate.validator.scripting.ScriptEngineScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluator;
import org.hibernate.validator.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.scripting.ScriptEvaluatorNotFoundException;
import org.hibernate.validator.spi.scripting.AbstractCachingScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEngineScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluator;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorFactory;
import org.hibernate.validator.spi.scripting.ScriptEvaluatorNotFoundException;
import org.osgi.framework.Bundle;
import org.osgi.framework.BundleContext;

Expand Down

0 comments on commit 9dea2e1

Please sign in to comment.