HV-446: Making docbook translation generation CLI configurable

hibernate · Mar 20, 2011 · baf1cca · baf1cca
1 parent 95789e9
commit baf1cca
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/hibernate-validator/pom.xml b/hibernate-validator/pom.xml
@@ -271,6 +271,15 @@
                     <sourceDocumentName>master.xml</sourceDocumentName>
                     <sourceDirectory>${basedir}/src/main/docbook</sourceDirectory>
                     <masterTranslation>en-US</masterTranslation>
+                    <translations>
+                        <translation>zh-CN</translation>
+                    </translations>
+                    <!-- 
+                        The jdookbook plug-in doesn't define an expression for this property, therefore
+                        it can't be passed on the command line. To address this issue the value is retrieved
+                        from a custom property, which itself can be set using -DignoreTranslations=...  
+                    -->
+                    <ignoreTranslations>${jdocbook.ignoreTranslations}</ignoreTranslations>
                     <imageResource>
                         <directory>${basedir}/src/main/docbook/en-US/images</directory>
                     </imageResource>
@@ -314,11 +323,6 @@
                             <goal>translate</goal>
                             <goal>generate</goal>
                         </goals>
-                        <configuration>
-                            <translations>
-                                <translation>zh-CN</translation>
-                            </translations>
-                        </configuration>
                     </execution>
                 </executions>
             </plugin>

diff --git a/pom.xml b/pom.xml
@@ -55,6 +55,7 @@
         <slf4jVersion>1.6.1</slf4jVersion>
         <!-- see http://maven.apache.org/general.html -->
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <jdocbook.ignoreTranslations>false</jdocbook.ignoreTranslations>
     </properties>
 
     <dependencyManagement>