HV-1284 Re-enable security manager for local TCK execution

hibernate · Mar 15, 2017 · f59d87d · f59d87d
1 parent f704f03
commit f59d87d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 24 deletions.
diff --git a/documentation/src/main/asciidoc/ch01.asciidoc b/documentation/src/main/asciidoc/ch01.asciidoc
@@ -99,6 +99,7 @@ The following shows how to do this via a http://docs.oracle.com/javase/8/docs/te
 grant codeBase "file:path/to/hibernate-validator-{hvVersion}.jar" {
     permission java.lang.reflect.ReflectPermission "suppressAccessChecks";
     permission java.lang.RuntimePermission "accessDeclaredMembers";
+    permission java.lang.RuntimePermission "setContextClassLoader";
 
     // Only needed when working with XML descriptors (validation.xml or XML constraint mappings)
     permission java.util.PropertyPermission "mapAnyUriToUri", "read";

diff --git a/tck-runner/pom.xml b/tck-runner/pom.xml
@@ -167,8 +167,10 @@
                 </property>
             </activation>
             <properties>
-                <!-- The properties "arquillian.protocol" and "surefire.argLine" are set based on this setting via GMaven-->
-                <with-security-manager>true</with-security-manager>
+                <!-- Use Local for testing without security manager -->
+                <arquillian.protocol>LocalSecurityManagerTesting</arquillian.protocol>
+                <!-- Remove for testing without security manager -->
+                <maven-surefire-plugin.argLine>-Djava.security.manager -Djava.security.policy=${project.build.directory}/test-classes/test.policy -Djava.security.debug=access</maven-surefire-plugin.argLine>
             </properties>
             <dependencies>
                 <dependency>
@@ -179,28 +181,6 @@
             </dependencies>
             <build>
                 <plugins>
-                    <plugin>
-                        <groupId>org.codehaus.gmavenplus</groupId>
-                        <artifactId>gmavenplus-plugin</artifactId>
-                        <executions>
-                            <execution>
-                                <id>configure-properties</id>
-                                <phase>validate</phase>
-                                <goals>
-                                    <goal>execute</goal>
-                                </goals>
-                                <configuration>
-                                    <scripts>
-                                        <script><![CDATA[
-                                            project.properties['arquillian.protocol'] = Boolean.valueOf(project.properties['with-security-manager']) ? 'LocalSecurityManagerTesting' : 'Local';
-                                            project.properties['surefire.argLine'] = Boolean.valueOf(project.properties['with-security-manager']) ? '-Djava.security.manager -Djava.security.policy=${project.build.directory}/test-classes/test.policy -Djava.security.debug=access' : '';
-                                            ]]>
-                                        </script>
-                                    </scripts>
-                                </configuration>
-                            </execution>
-                        </executions>
-                    </plugin>
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-surefire-plugin</artifactId>

diff --git a/tck-runner/src/test/resources/test.policy b/tck-runner/src/test/resources/test.policy
@@ -26,6 +26,7 @@
 grant codeBase "file:${localRepository}/org/hibernate/hibernate-validator/${project.version}/hibernate-validator-${project.version}.jar" {
     permission java.lang.reflect.ReflectPermission "suppressAccessChecks";
     permission java.lang.RuntimePermission "accessDeclaredMembers";
+    permission java.lang.RuntimePermission "setContextClassLoader";
 
     // JAXB
     permission java.util.PropertyPermission "mapAnyUriToUri", "read";
@@ -36,6 +37,7 @@ grant codeBase "file:${localRepository}/org/hibernate/hibernate-validator/${proj
 grant codeBase "file:${basedir}/../engine/target/hibernate-validator-${project.version}.jar" {
     permission java.lang.reflect.ReflectPermission "suppressAccessChecks";
     permission java.lang.RuntimePermission "accessDeclaredMembers";
+    permission java.lang.RuntimePermission "setContextClassLoader";
 
     // JAXB
     permission java.util.PropertyPermission "mapAnyUriToUri", "read";