Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HV-1729 Skip allocation of an action for each need to access the con… #1048

Closed
wants to merge 1 commit into from

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Aug 2, 2019

@gsmet gsmet changed the title HV-1729 Skip allocattion of an action for each need to access the con… HV-1729 Skip allocation of an action for each need to access the con… Aug 2, 2019
@gsmet
Copy link
Member

gsmet commented Aug 2, 2019

Merged to 6.0, 6.2 and master branches.

@gsmet gsmet closed this Aug 2, 2019
@gsmet
Copy link
Member

gsmet commented Aug 2, 2019

Thanks!

@gsmet
Copy link
Member

gsmet commented Aug 2, 2019

BTW, is this something we use at runtime (runtime definition is a bit loose here, I mean once the metadata have been initialized for a given bean class)? Because I would have expected this to only be called when bootstrapping the metadata and never after that.

The metadata initialization is far from being optimized. Typically, we do a lot of map allocations when calling reflection methods repeatedly (we should call the method once and pass the result everywhere). That's an area of improvement for when time permits.

@Sanne
Copy link
Member Author

Sanne commented Aug 2, 2019

I haven't seen evidence of it being used at runtime - so not sure.

I was actually checking something else, then couldn't help fixing this :)

@Sanne Sanne deleted the HV-1729 branch August 12, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants