Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HV-100 #118

Merged
merged 6 commits into from
Apr 20, 2012
Merged

HV-100 #118

merged 6 commits into from
Apr 20, 2012

Conversation

hferentschik
Copy link
Contributor

I think the basic harness is ready to get pulled in. The test need probably more work (refining existing tests, adding new ones). Looking for some feedback there.

Things should be described in the readme.md. Let me know whether things are unclear or do not work.

<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</dependency>
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does JMeter only support JUnit as testing framework? Or could we use TestNG here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only JUnit is supported. I would have preferred TestNG (mainly out of consistency) as well, but in this case some more dirty work is needed.

…. Removing random depth generation in StatisticalValidationTest
…rs. Cleaning up tests and package names. Adding information to readme
@hferentschik
Copy link
Contributor Author

@gunnarmorling I removed the unnecessary commit and rebased everything

@gunnarmorling gunnarmorling merged commit 76fd73f into hibernate:master Apr 20, 2012
@gunnarmorling
Copy link
Member

I think the harness is a great base for further tests. Especially I like the idea of the different profiles for the different versions, this allows for great comparing analyses.

How are your numbers for HV 4.2 vs. 4.3? The former is several times faster on my machine. I'm wondering what the reason is.

@gunnarmorling
Copy link
Member

Ah I see, the improvements you mentioned are in the HV-538 branch; there the numbers look indeed much better.

@hferentschik
Copy link
Contributor Author

How are your numbers for HV 4.2 vs. 4.3? The former is several times faster on my machine. I'm wondering what the reason is.

Mainly the SoftLimitMRUMap and the Contracts class. Things look much better on the HV-538 branch

Ah I see, the improvements you mentioned are in the HV-538 branch

:-) and looking much better again. we also don't have to shy the comparison with bval
If you think the changes for HV-538 are ok, I can create a pull request there as well

@gunnarmorling
Copy link
Member

If you think the changes for HV-538 are ok, I can create a pull request there as well

I'm looking into this right now. the new map looks promising, I think it's similar to the one from Google Guava.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants