-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HV-100 #118
HV-100 #118
Conversation
<groupId>org.slf4j</groupId> | ||
<artifactId>slf4j-log4j12</artifactId> | ||
</dependency> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does JMeter only support JUnit as testing framework? Or could we use TestNG here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only JUnit is supported. I would have preferred TestNG (mainly out of consistency) as well, but in this case some more dirty work is needed.
…. Removing random depth generation in StatisticalValidationTest
…rs. Cleaning up tests and package names. Adding information to readme
@gunnarmorling I removed the unnecessary commit and rebased everything |
I think the harness is a great base for further tests. Especially I like the idea of the different profiles for the different versions, this allows for great comparing analyses. How are your numbers for HV 4.2 vs. 4.3? The former is several times faster on my machine. I'm wondering what the reason is. |
Ah I see, the improvements you mentioned are in the HV-538 branch; there the numbers look indeed much better. |
Mainly the SoftLimitMRUMap and the Contracts class. Things look much better on the HV-538 branch
:-) and looking much better again. we also don't have to shy the comparison with bval |
I'm looking into this right now. the new map looks promising, I think it's similar to the one from Google Guava. |
I think the basic harness is ready to get pulled in. The test need probably more work (refining existing tests, adding new ones). Looking for some feedback there.
Things should be described in the readme.md. Let me know whether things are unclear or do not work.