HV-1494 hibernate validator error when @NotEmpty used on return type #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation were not giving a chance for composite constraints to execute if they were placed on a method with non void return type and parameters
|
@gsmet sooo you were asking about this one in JIRA. Here's what I have atm. |
|
closing this one in favor of #863 |
| if ( constraintType == null ) { | ||
| throw LOG.getImplicitConstraintTargetInAmbiguousConfigurationException( annotationType ); | ||
| // check if it's a composite constraint and is built with constraints for which a type can be detected | ||
| Set<ConstraintType> constraintTypes = findComposingConstraints( constraintHelper ) |
There was a problem hiding this comment.
We already call parseComposingConstraints(); could we somehow combine this, instead of running the annotation tree another time?
There was a problem hiding this comment.
Ok, I'll see what can be done about it and open another PR if something good comes out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation were not giving a chance for composite constraints to execute if they were placed on a method with non void return type and parameters - as for those both
hasGenericValidatorsandhasCrossParameterValidatorwerefalseand there's no way to setvalidationAppliesTosoConstraintDescriptorImpl#determineConstraintTypewas just skipping to:hence there was no way to use them on methods with both return value and parameters....
Let me know what you think about these changes :)