HV-1461 ExecutableHelper#overrides does not work correctly with the method containing generic and non generic parameters

[marko-bekhta]

• https://hibernate.atlassian.net/browse/HV-1461

As it turned out the upgrade of classmate in da94fc5 from 1.3.1 to 1.3.3 done the trick. So I've just added a test case similar to the one in the JIRA. In case of 1.3.1 version in ExecutableHelper#instanceMethodParametersResolveToSameTypes you would get:

resolvedMethods[0].getArgumentType( i ) = {ResolvedObjectType@1491} "java.lang.Long"
resolvedMethods[1].getArgumentType( i ) = {ResolvedObjectType@1493} "java.lang.Long<org.hibernate.validator.test.internal.util.ExecutableHelperTest$Bar>"

and in case of 1.3.3:

resolvedMethods[0].getArgumentType( i ) = {ResolvedObjectType@1468} "java.lang.Long"
resolvedMethods[1].getArgumentType( i ) = {ResolvedObjectType@1470} "java.lang.Long"

If a backport for the fix is needed and we cannot upgrade the lib version a simple use of .getErasedType() on both sides of argument equals check:

if ( !resolvedMethods[0].getArgumentType( i ).getErasedType().equals( resolvedMethods[1].getArgumentType( i ).getErasedType() ) ) {
	return false;
}

in that same method will do the trick.

[gsmet]

Merged, thanks!