-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): correct panic error #758
feat(*): correct panic error #758
Conversation
e25d45e
to
6937ba2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #758 +/- ##
==========================================
- Coverage 68.41% 68.26% -0.16%
==========================================
Files 27 27
Lines 3841 3841
==========================================
- Hits 2628 2622 -6
- Misses 929 934 +5
- Partials 284 285 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc/ @hibiken
@linhbkhn95 Would you mind rebasing the branch and resolving conflicts? |
@hibiken I rebased and resolved the conflict. Please merge it |
@hibiken Good fix, ready for merge. I'm prepping v0.25.0 but we should include this. |
LGTM - please resolve conflicts and merge |
1e6b5c4
to
d00e218
Compare
d00e218
to
4cee58e
Compare
don't have any conflict, can you check it? @hibiken |
* error panic handling * updated CHANGELOG.md file * correct msg panic error (hibiken#5) * correct msg panic error
Background
Currently, the Panic error show seems redundant with the processor error log.
Why did we need it?
Correct panic error msg
Issue Link
#745