Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go:build for BSD #843

Merged
merged 1 commit into from Mar 15, 2024
Merged

Fix go:build for BSD #843

merged 1 commit into from Mar 15, 2024

Conversation

mrusme
Copy link
Contributor

@mrusme mrusme commented Mar 14, 2024

I've been running into the following build issue on a project that uses asynq:

  ⨯ release failed after 5m12s               error=failed to build for openbsd_386: exit status 1: # github.com/hibiken/asynq
Error: ../../../go/pkg/mod/github.com/hibiken/asynq@v0.24.1/periodic_task_manager.go:152:8: mgr.s.waitForSignals undefined (type *Scheduler has no field or method waitForSignals)
Error: ../../../go/pkg/mod/github.com/hibiken/asynq@v0.24.1/scheduler.go:212:4: s.waitForSignals undefined (type *Scheduler has no field or method waitForSignals)
Error: ../../../go/pkg/mod/github.com/hibiken/asynq@v0.24.1/server.go:594:6: srv.waitForSignals undefined (type *Server has no field or method waitForSignals)
Error: The process '/opt/hostedtoolcache/goreleaser-action/1.24.0/x64/goreleaser' failed with exit code 1

Upon fruther investigation it appears that the go:build flag bsd is not correct. The go tool dist list command doesn't list any platform named bsd. Hence I believe bsd needs to be replaced with the actual BSD platforms. I don't know whether you would want to include solaris as well, and whether there's anyone using it/able to test it on that platform, hence I left it out.

mrusme added a commit to mrusme/overpush that referenced this pull request Mar 14, 2024
Copy link
Collaborator

@kamikazechaser kamikazechaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.41%. Comparing base (38f7499) to head (b25d10b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #843   +/-   ##
=======================================
  Coverage   68.41%   68.41%           
=======================================
  Files          27       27           
  Lines        3841     3841           
=======================================
  Hits         2628     2628           
  Misses        929      929           
  Partials      284      284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamikazechaser kamikazechaser merged commit 8df0bfa into hibiken:master Mar 15, 2024
9 checks passed
@mrusme mrusme deleted the fix-bsd branch March 15, 2024 13:36
mrusme added a commit to mrusme/overpush that referenced this pull request Mar 15, 2024
@mrusme
Copy link
Contributor Author

mrusme commented Mar 15, 2024

Tested, works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants